Fix psalm errors #1209
Fix psalm errors #1209
Conversation
| <LessSpecificReturnStatement> | ||
| <code><![CDATA[(object) $this->getArrayCopy()]]></code> | ||
| </LessSpecificReturnStatement> | ||
| <MixedAssignment> | ||
| <code>$this[$key]</code> | ||
| <code>$value</code> | ||
| </MixedAssignment> | ||
| <MoreSpecificReturnType> | ||
| <code>stdClass</code> | ||
| </MoreSpecificReturnType> |
There was a problem hiding this comment.
The LessSpecificReturnStatement and MoreSpecificReturnType are due to vimeo/psalm#8187. In essence, Psalm takes the return value of (object) [] to be object, even though it is stdClass.
| <MixedArgument> | ||
| <code><![CDATA[$options['codec'] ?? null]]></code> | ||
| </MixedArgument> |
There was a problem hiding this comment.
Not sure why this errors in that one specific file - it works in all other files where we have the same checks on the codec option and then use it in a typed context 🤷
There was a problem hiding this comment.
I couldn't reproduce.
https://psalm.dev/r/609a35bce9
alcaeus
force-pushed
the
fix-psalm-errors
branch
from
064bbed to
2651e38
Compare
alcaeus
force-pushed
the
fix-psalm-errors
branch
from
2651e38 to
6ac6209
Compare
Yes, perhaps paired with dependabot updating the version constraint range when an update was released. I'll give it some thought. |
* v1.17: Fix psalm errors (#1209)
This fixes a couple of errors that appeared due to a psalm update which updated the PHPC method signatures.